From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGfm4-0002up-Aa
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 17:00:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGflz-0002sS-QL
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 17:00:55 -0400
Received: from [199.232.76.173] (port=42944 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGflz-0002sK-Kh
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 17:00:51 -0400
Received: from mx2.redhat.com ([66.187.237.31]:33566)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MGfly-0000LJ-T6
	for qemu-devel@nongnu.org; Tue, 16 Jun 2009 17:00:51 -0400
Message-ID: <4A38077D.8090704@redhat.com>
Date: Tue, 16 Jun 2009 22:58:37 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] qdev: Fix regression in "pci_add ... storage
	if=virtio, ..."
References: <87bpowhtmm.fsf@pike.pond.sub.org>
	<87my88uuhf.fsf@pike.pond.sub.org>
In-Reply-To: <87my88uuhf.fsf@pike.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, paul@codesourcery.com

   Hi,

>       case IF_VIRTIO:
>           opaque = pci_create_simple(pci_bus, -1, "virtio-blk-pci");
> -        qdev_init(opaque);
>           break;

Yep, pci_create_simple() calls qdev_init() already.
Patch looks good.

cheers,
   Gerd