From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGxXr-0000Ub-6O
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 11:59:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGxXl-0000Pu-7j
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 11:59:25 -0400
Received: from [199.232.76.173] (port=45397 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGxXk-0000Pm-Ui
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 11:59:21 -0400
Received: from mail-qy0-f191.google.com ([209.85.221.191]:34685)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MGxXk-0001V5-JT
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 11:59:20 -0400
Received: by qyk29 with SMTP id 29so509012qyk.4
	for <qemu-devel@nongnu.org>; Wed, 17 Jun 2009 08:59:17 -0700 (PDT)
Message-ID: <4A3912D1.3000604@codemonkey.ws>
Date: Wed, 17 Jun 2009 10:59:13 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/4] Expose fw_cfg
References: <1245250604-6291-1-git-send-email-agraf@suse.de>	<1245250604-6291-2-git-send-email-agraf@suse.de>	<1245250604-6291-3-git-send-email-agraf@suse.de>	<f43fc5580906170830q665b6e60k245bc400277e8599@mail.gmail.com>
	<687B8C48-A0DB-4D2E-9D79-20706DB23C2B@suse.de>
In-Reply-To: <687B8C48-A0DB-4D2E-9D79-20706DB23C2B@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, kwolf@redhat.com, rene@exactcode.de, qemu-devel@nongnu.org

Alexander Graf wrote:
>
> On 17.06.2009, at 17:30, Blue Swirl wrote:
>
>> On 6/17/09, Alexander Graf <agraf@suse.de> wrote:
>>> Multiboot passes options to the option rom using the fw_cfg device.
>>> Right now, that device is local to the bochs_bios_init function.
>>>
>>> Let's change that and expose it to env, so everyone may put data
>>> in there.
>>
>> Env is a wrong place for device data.
>
> So what is the right place? Last time I checked there wasn't anything 
> like a global pc machine state struct, but I could be wrong.

Return fw_cfg from bochs_bios_init, then pass it to the kernel loading 
functions.

Regards,

Anthony Liguori

> Alex
>
>