From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MGy8x-00081g-E1
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 12:37:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MGy8s-0007wa-Pb
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 12:37:46 -0400
Received: from [199.232.76.173] (port=37358 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MGy8r-0007w6-QM
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 12:37:41 -0400
Received: from lizzard.sbs.de ([194.138.37.39]:18126)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1MGy8o-0001GP-M5
	for qemu-devel@nongnu.org; Wed, 17 Jun 2009 12:37:41 -0400
Message-ID: <4A391BCD.8010300@siemens.com>
Date: Wed, 17 Jun 2009 18:37:33 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1245253660-12616-1-git-send-email-uli@suse.de>
	<5b31733c0906170906h382761aekc7e898e94dc0ea1d@mail.gmail.com>
In-Reply-To: <5b31733c0906170906h382761aekc7e898e94dc0ea1d@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] warnings in net.c
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Filip Navara <filip.navara@gmail.com>
Cc: qemu-devel@nongnu.org

Filip Navara wrote:
> On Wed, Jun 17, 2009 at 5:47 PM, Ulrich Hecht <uli@suse.de> wrote:
> 
>> removes unused slirp code and initializes ret in net_client_init()
>>
>> Signed-off-by: Ulrich Hecht <uli@suse.de>
> 
> 
> It is definitely not unused when CONFIG_SLIRP is defined. I'm damn sure I
> use the code and that I was debugging it two days ago.

Right, the patch is incorrect. And even with --disable-slirp, it builds
fine for me as-is. Ulrich, what is your setup (configure parameters etc.)?

Also, the ret initialization appears to be unneeded on first glance. No
compiler around has a problem with it. What is your version / setup
here? And more important: What path requires the initialization (because
it remains unclear if ret=0 is the correct until we know the precise case).

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux