From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MHB6h-00028u-19
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 02:28:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MHB6b-00023c-SQ
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 02:28:17 -0400
Received: from [199.232.76.173] (port=55478 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MHB6b-00023V-LY
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 02:28:13 -0400
Received: from mx2.redhat.com ([66.187.237.31]:52752)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MHB6b-0002gG-6z
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 02:28:13 -0400
Message-ID: <4A39DE69.4040308@redhat.com>
Date: Thu, 18 Jun 2009 08:27:53 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2] alsa: fix warning
References: <1245239480-23687-1-git-send-email-kraxel@redhat.com>
	<Pine.LNX.4.64.0906172215220.2192@linmac.oyster.ru>
In-Reply-To: <Pine.LNX.4.64.0906172215220.2192@linmac.oyster.ru>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org

On 06/17/09 20:15, malc wrote:
> On Wed, 17 Jun 2009, Gerd Hoffmann wrote:
>
>> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>> ---
>>   audio/alsaaudio.c |   10 ++++++----
>>   1 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
>> index 2f6c764..f1d573a 100644
>> --- a/audio/alsaaudio.c
>> +++ b/audio/alsaaudio.c
>> @@ -626,8 +626,9 @@ static int alsa_init_out (HWVoiceOut *hw, struct a=
udsettings *as)
>>       req.period_size =3D conf.period_size_out;
>>       req.buffer_size =3D conf.buffer_size_out;
>>       req.size_in_usec =3D conf.size_in_usec_out;
>> -    req.override_mask =3D !!conf.period_size_out_overridden
>> -        | (!!conf.buffer_size_out_overridden<<  1);
>> +    req.override_mask =3D
>> +        (conf.period_size_out_overridden ? 1 : 0) |
>> +        (conf.buffer_size_out_overridden ? 2 : 0);
>>
> [..snip..]
>
> What warning does that fix?
>

   CC    audio/alsaaudio.o
cc1: warnings being treated as errors
/home/kraxel/projects/qemu/audio/alsaaudio.c: In function =91alsa_init_ou=
t=92:
/home/kraxel/projects/qemu/audio/alsaaudio.c:630: error: suggest=20
parentheses around operand of =91!=92 or change =91|=92 to =91||=92 or =91=
!=92 to =91~=92
/home/kraxel/projects/qemu/audio/alsaaudio.c: In function =91alsa_init_in=
=92:
/home/kraxel/projects/qemu/audio/alsaaudio.c:710: error: suggest=20
parentheses around operand of =91!=92 or change =91|=92 to =91||=92 or =91=
!=92 to =91~=92
make: *** [audio/alsaaudio.o] Error 1

cheers,
   Gerd