From: Gerd Hoffmann <kraxel@redhat.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>,
aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] allow for name property in pci devices.
Date: Thu, 18 Jun 2009 11:54:36 +0200 [thread overview]
Message-ID: <4A3A0EDC.8010106@redhat.com> (raw)
In-Reply-To: <1245310421.675.41.camel@blaa>
On 06/18/09 09:33, Mark McLoughlin wrote:
>> - pci_dev = do_pci_register_device(pci_dev, bus, "FIXME", devfn,
>> + name = qdev_get_prop_ptr(qdev, "name");
>> +
>> + pci_dev = do_pci_register_device(pci_dev, bus, name, devfn,
>> NULL, NULL);//FIXME:config_read, config_write);
>
> Why not just use base->name here?
+1
While we are at it: Do we need the name field in PCIDevice the first
place then? Well, maybe better keep it until all pci devices are moved
over to qdev.
cheers,
Gerd
prev parent reply other threads:[~2009-06-18 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 13:13 [Qemu-devel] [PATCH] allow for name property in pci devices Glauber Costa
2009-06-17 13:46 ` Paul Brook
2009-06-18 7:33 ` Mark McLoughlin
2009-06-18 9:54 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3A0EDC.8010106@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).