From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHEKU-00079L-Qi for qemu-devel@nongnu.org; Thu, 18 Jun 2009 05:54:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHEKQ-00077W-0B for qemu-devel@nongnu.org; Thu, 18 Jun 2009 05:54:46 -0400 Received: from [199.232.76.173] (port=36814 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHEKP-00077S-RD for qemu-devel@nongnu.org; Thu, 18 Jun 2009 05:54:41 -0400 Received: from mx2.redhat.com ([66.187.237.31]:57780) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MHEKP-0001Qx-6U for qemu-devel@nongnu.org; Thu, 18 Jun 2009 05:54:41 -0400 Message-ID: <4A3A0EDC.8010106@redhat.com> Date: Thu, 18 Jun 2009 11:54:36 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] allow for name property in pci devices. References: <1245244380-27863-1-git-send-email-glommer@redhat.com> <1245310421.675.41.camel@blaa> In-Reply-To: <1245310421.675.41.camel@blaa> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark McLoughlin Cc: Glauber Costa , aliguori@us.ibm.com, qemu-devel@nongnu.org On 06/18/09 09:33, Mark McLoughlin wrote: >> - pci_dev = do_pci_register_device(pci_dev, bus, "FIXME", devfn, >> + name = qdev_get_prop_ptr(qdev, "name"); >> + >> + pci_dev = do_pci_register_device(pci_dev, bus, name, devfn, >> NULL, NULL);//FIXME:config_read, config_write); > > Why not just use base->name here? +1 While we are at it: Do we need the name field in PCIDevice the first place then? Well, maybe better keep it until all pci devices are moved over to qdev. cheers, Gerd