From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHEMG-0007kz-NS for qemu-devel@nongnu.org; Thu, 18 Jun 2009 05:56:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHEMB-0007k8-TG for qemu-devel@nongnu.org; Thu, 18 Jun 2009 05:56:35 -0400 Received: from [199.232.76.173] (port=36843 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHEMA-0007k4-QD for qemu-devel@nongnu.org; Thu, 18 Jun 2009 05:56:30 -0400 Received: from mx2.redhat.com ([66.187.237.31]:35311) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MHEMA-0001i2-8Z for qemu-devel@nongnu.org; Thu, 18 Jun 2009 05:56:30 -0400 Message-ID: <4A3A0F5F.8090007@redhat.com> Date: Thu, 18 Jun 2009 12:56:47 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/4] Multiboot support v2 References: <1245256873-8010-1-git-send-email-agraf@suse.de> <1245256873-8010-2-git-send-email-agraf@suse.de> <1245256873-8010-3-git-send-email-agraf@suse.de> <1245256873-8010-4-git-send-email-agraf@suse.de> In-Reply-To: <1245256873-8010-4-git-send-email-agraf@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: kwolf@redhat.com, rene@exactcode.de, qemu-devel@nongnu.org On 06/17/2009 07:41 PM, Alexander Graf wrote: > This patch implements support for Multiboot on x86 for -kernel. > Multiboot is a "new" approach to get rid of different bootloaders, providing > a unified interface for the kernel. It supports command line options and > kernel modules. > > The two probably best known projects using multiboot are Xen and GNU Hurd. > > This implementation should be mostly feature-complete. It is missing VBE > extensions, but as no system uses them currently it does not really hurt. > > To use multiboot, specify the kernel as -kernel option. Modules should be given > as -initrd options, seperated by a comma (,). -append also works. > > Please bear in mind that grub also does gzip decompression, which qemu does > not do yet. To run existing images, please ungzip them first. > > The guest multiboot loader code is implemented as option rom using int 19. > Parts of the work are based on efforts by Rene Rebe, who originally ported > my code to int 19. > This will be very useful for running test cases. > + /* Ok, let's see if it is a multiboot image. > + The header is 12x32bit long, so the latest entry may be 8192 - 48. */ > + for(i = 0; i< (8192 - 48); i += 4) { > Here (and in many other places in the patch) you have a control flow keyword followed immediately by a parentheses, so it looks like a function call. Really reduced readability IMO. -- error compiling committee.c: too many arguments to function