From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MHFeE-0003Lj-In for qemu-devel@nongnu.org; Thu, 18 Jun 2009 07:19:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MHFeA-0003Jf-4X for qemu-devel@nongnu.org; Thu, 18 Jun 2009 07:19:14 -0400 Received: from [199.232.76.173] (port=37786 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MHFe9-0003JS-P1 for qemu-devel@nongnu.org; Thu, 18 Jun 2009 07:19:09 -0400 Received: from mx2.redhat.com ([66.187.237.31]:53162) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MHFe8-0000o2-MO for qemu-devel@nongnu.org; Thu, 18 Jun 2009 07:19:09 -0400 Message-ID: <4A3A22BD.70201@redhat.com> Date: Thu, 18 Jun 2009 14:19:25 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/4] Multiboot support v2 References: <1245256873-8010-1-git-send-email-agraf@suse.de> <1245256873-8010-2-git-send-email-agraf@suse.de> <1245256873-8010-3-git-send-email-agraf@suse.de> <1245256873-8010-4-git-send-email-agraf@suse.de> <4A3A0F5F.8090007@redhat.com> <662EA648-D416-4632-9095-DF622950E955@suse.de> In-Reply-To: <662EA648-D416-4632-9095-DF622950E955@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: kwolf@redhat.com, rene@exactcode.de, qemu-devel@nongnu.org On 06/18/2009 01:22 PM, Alexander Graf wrote: > Looking through pc.c I found for mostly without space, but if with > immediate space after it. > pc.c: [avi@cleopatra qemu-kvm (master)]$ grep -c -F 'if (' hw/pc.c 99 [avi@cleopatra qemu-kvm (master)]$ grep -c -F 'if(' hw/pc.c 0 [avi@cleopatra qemu-kvm (master)]$ grep -c -F 'for (' hw/pc.c 13 [avi@cleopatra qemu-kvm (master)]$ grep -c -F 'for(' hw/pc.c 8 the entire tree: [avi@cleopatra qemu-kvm (1b443f4...)]$ git ls-files | xargs cat | grep -c -F 'if (' 25831 [avi@cleopatra qemu-kvm (1b443f4...)]$ git ls-files | xargs cat | grep -c -F 'if(' 711 [avi@cleopatra qemu-kvm (1b443f4...)]$ git ls-files | xargs cat | grep -c -F 'for (' 2085 [avi@cleopatra qemu-kvm (1b443f4...)]$ git ls-files | xargs cat | grep -c -F 'for(' 906 The spaces win. > Wouldn't it be more useful to write some automatic formatting script > git would run on patches that go in? Maybe people using tabs in the > wrong areas of the code would be able to submit patches by then too ;-). > > IMHO there is no real "qemu coding style" atm anyway - each maintainer > has his own and uses that for its subtree. It'd be a lot more helpful > to start addressing things at the root of the problems. > There's CODING_STYLE (which doesn't address this bit, but is a start). -- error compiling committee.c: too many arguments to function