From: Gerd Hoffmann <kraxel@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] replace duplicated code.
Date: Thu, 18 Jun 2009 16:33:02 +0200 [thread overview]
Message-ID: <4A3A501E.8080600@redhat.com> (raw)
In-Reply-To: <20090618135950.GF3517@poweredge.glommer>
On 06/18/09 15:59, Glauber Costa wrote:
>> You have changed the ordering of the qdev_set_netdev and qdev_init
>> calls. I don't think this is correct, the init callback will not see
>> the nicinfo then.
> I see.
>
> How would you feel about changing the nd field of qdev for a void * one,
> call it private, or whatever?
>
> then we could have a generic qdev_set_private(dev, p), that does it for
> everybody. I must say I kinda dislike that specific dependency on nd for
> net devices. Ideally, all devices should be treated as the same.
What problem you are trying to solve?
Unless there is something urgent to fix I'd leave it as is for now.
We need some sane way to link guest config (hopefully done by config
file soon) to host config. Link nic to vlan in that case, but disks and
chardevs share the same issue. I consider DeviceState->nd being
temporary and expect will go away once we figured that out. It is a
bigger undertaking though ...
cheers,
Gerd
prev parent reply other threads:[~2009-06-18 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 22:52 [Qemu-devel] [PATCH] replace duplicated code Glauber Costa
2009-06-18 7:39 ` Mark McLoughlin
2009-06-18 9:48 ` Gerd Hoffmann
2009-06-18 13:59 ` Glauber Costa
2009-06-18 14:33 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3A501E.8080600@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=glommer@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).