From: Jan Kiszka <jan.kiszka@web.de>
To: Ulrich Hecht <uli@suse.de>
Cc: Filip Navara <filip.navara@gmail.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] warnings in net.c
Date: Thu, 18 Jun 2009 20:31:56 +0200 [thread overview]
Message-ID: <4A3A881C.9070000@web.de> (raw)
In-Reply-To: <200906181156.06180.uli@suse.de>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
Ulrich Hecht wrote:
> On Wednesday 17 June 2009, Filip Navara wrote:
>> On Wed, Jun 17, 2009 at 5:47 PM, Ulrich Hecht <uli@suse.de> wrote:
>>> removes unused slirp code and initializes ret in net_client_init()
>>>
>>> Signed-off-by: Ulrich Hecht <uli@suse.de>
>> It is definitely not unused when CONFIG_SLIRP is defined. I'm damn
>> sure I use the code and that I was debugging it two days ago.
>
> Er, yes, now that you mention it... I even grepped for net_client_init,
> but I didn't find it.
>
> Still, it dies thanks to -Werror with a plain "./configure". I guess
> framing it with #ifdef CONFIG_SLIRP will do.
It _is_ already framed, and it _does_ build flawlessly with
--disable-slirp here. You must be looking at a different version.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-06-18 18:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 15:47 [Qemu-devel] [PATCH] warnings in net.c Ulrich Hecht
2009-06-17 16:06 ` Filip Navara
2009-06-17 16:37 ` [Qemu-devel] " Jan Kiszka
2009-06-18 10:01 ` Ulrich Hecht
2009-06-18 9:56 ` [Qemu-devel] " Ulrich Hecht
2009-06-18 18:31 ` Jan Kiszka [this message]
2009-06-17 16:23 ` Blue Swirl
-- strict thread matches above, loose matches on Subject: below --
2009-07-03 15:09 [Qemu-devel] [PATCH 0/4] linux-user syscall bugs Ulrich Hecht
2009-07-03 15:09 ` [Qemu-devel] [PATCH 1/4] pipe argument should not be signed Ulrich Hecht
2009-07-03 15:09 ` [Qemu-devel] [PATCH] warnings in net.c Ulrich Hecht
2009-07-03 15:10 ` [Qemu-devel] " Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3A881C.9070000@web.de \
--to=jan.kiszka@web.de \
--cc=filip.navara@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=uli@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).