From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MHMPA-0003x0-60
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 14:32:08 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MHMP5-0003ko-Az
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 14:32:07 -0400
Received: from [199.232.76.173] (port=40660 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MHMP5-0003ke-77
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 14:32:03 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:40083)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1MHMP4-0007IG-KL
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 14:32:02 -0400
Message-ID: <4A3A881C.9070000@web.de>
Date: Thu, 18 Jun 2009 20:31:56 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <1245253660-12616-1-git-send-email-uli@suse.de>	<5b31733c0906170906h382761aekc7e898e94dc0ea1d@mail.gmail.com>
	<200906181156.06180.uli@suse.de>
In-Reply-To: <200906181156.06180.uli@suse.de>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig8168E5DD00835B9757CE3254"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH] warnings in net.c
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ulrich Hecht <uli@suse.de>
Cc: Filip Navara <filip.navara@gmail.com>, qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig8168E5DD00835B9757CE3254
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Ulrich Hecht wrote:
> On Wednesday 17 June 2009, Filip Navara wrote:
>> On Wed, Jun 17, 2009 at 5:47 PM, Ulrich Hecht <uli@suse.de> wrote:
>>> removes unused slirp code and initializes ret in net_client_init()
>>>
>>> Signed-off-by: Ulrich Hecht <uli@suse.de>
>> It is definitely not unused when CONFIG_SLIRP is defined. I'm damn
>> sure I use the code and that I was debugging it two days ago.
>=20
> Er, yes, now that you mention it... I even grepped for net_client_init,=
=20
> but I didn't find it.
>=20
> Still, it dies thanks to -Werror with a plain "./configure". I guess=20
> framing it with #ifdef CONFIG_SLIRP will do.

It _is_ already framed, and it _does_ build flawlessly with
--disable-slirp here. You must be looking at a different version.

Jan


--------------enig8168E5DD00835B9757CE3254
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAko6iCAACgkQniDOoMHTA+lzwgCcD6G02U6jA3wKRw85UFpDZ9o5
k2IAn2ou/IxmbD+oeL/vqI/3OWavjBXz
=yDCU
-----END PGP SIGNATURE-----

--------------enig8168E5DD00835B9757CE3254--