From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] Win32: Fix compilation with SDL.
Date: Thu, 18 Jun 2009 15:00:14 -0500 [thread overview]
Message-ID: <4A3A9CCE.4060005@codemonkey.ws> (raw)
In-Reply-To: <4A3A92BD.2080708@mail.berlios.de>
Stefan Weil wrote:
> Ah, ok: it's simply a bad prototype of SDL_config:
>
> extern C_LINKAGE int SDL_main(int argc, char *argv[]);
>
> QEMU's main does not match:
> int main(int argc, char **argv, char **envp)
>
> So just redefining main will result in a wrong SDL_main
> with 3 instead of 2 arguments.
>
Can we not use getenv() instead of envp in main()? This was introduced
for cache-utils which looks to be PPC specific.
Regards,
Anthony Liguori
> Regards,
> Stefan Weil
>
>
next prev parent reply other threads:[~2009-06-18 20:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 18:11 [Qemu-devel] [PATCH] Win32: Fix compilation with SDL Stefan Weil
2009-06-18 18:46 ` Anthony Liguori
2009-06-18 19:01 ` Stefan Weil
2009-06-18 19:12 ` Anthony Liguori
2009-06-18 19:17 ` Stefan Weil
2009-06-18 20:00 ` Anthony Liguori [this message]
2009-06-18 20:49 ` Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3A9CCE.4060005@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=hollisb@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).