From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MHNmY-0003R2-UB
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 16:00:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MHNmU-0003Pz-FL
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 16:00:22 -0400
Received: from [199.232.76.173] (port=48375 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MHNmU-0003Pw-BW
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 16:00:18 -0400
Received: from qw-out-1920.google.com ([74.125.92.147]:43162)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MHNmT-0002Lr-SR
	for qemu-devel@nongnu.org; Thu, 18 Jun 2009 16:00:18 -0400
Received: by qw-out-1920.google.com with SMTP id 4so684906qwk.4
	for <qemu-devel@nongnu.org>; Thu, 18 Jun 2009 13:00:17 -0700 (PDT)
Message-ID: <4A3A9CCE.4060005@codemonkey.ws>
Date: Thu, 18 Jun 2009 15:00:14 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Win32: Fix compilation with SDL.
References: <1245348663-9022-1-git-send-email-weil@mail.berlios.de>
	<4A3A8B77.2020109@codemonkey.ws> <4A3A8F22.2080907@mail.berlios.de>
	<4A3A91A5.4080209@codemonkey.ws> <4A3A92BD.2080708@mail.berlios.de>
In-Reply-To: <4A3A92BD.2080708@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Hollis Blanchard <hollisb@us.ibm.com>

Stefan Weil wrote:
> Ah, ok: it's simply a bad prototype of SDL_config:
>
> extern C_LINKAGE int SDL_main(int argc, char *argv[]);
>
> QEMU's main does not match:
> int main(int argc, char **argv, char **envp)
>
> So just redefining main will result in a wrong SDL_main
> with 3 instead of 2 arguments.
>   

Can we not use getenv() instead of envp in main()?  This was introduced 
for cache-utils which looks to be PPC specific.

Regards,

Anthony Liguori

> Regards,
> Stefan Weil
>
>