From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MHZ9q-0006Dq-OK
	for qemu-devel@nongnu.org; Fri, 19 Jun 2009 04:09:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MHZ9l-00066u-Lj
	for qemu-devel@nongnu.org; Fri, 19 Jun 2009 04:09:09 -0400
Received: from [199.232.76.173] (port=57474 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MHZ9l-00066Z-Bz
	for qemu-devel@nongnu.org; Fri, 19 Jun 2009 04:09:05 -0400
Received: from mx2.redhat.com ([66.187.237.31]:53667)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kwolf@redhat.com>) id 1MHZ9k-0006vS-SK
	for qemu-devel@nongnu.org; Fri, 19 Jun 2009 04:09:05 -0400
Message-ID: <4A3B4754.7070607@redhat.com>
Date: Fri, 19 Jun 2009 10:07:48 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v4 01/12] fix qemu_alloc/qemu_free for block
	subsystem
References: <y> <1245358219-13170-1-git-send-email-jcd@tribudubois.net>
	<1245358219-13170-2-git-send-email-jcd@tribudubois.net>
In-Reply-To: <1245358219-13170-2-git-send-email-jcd@tribudubois.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jean-Christophe DUBOIS <jcd@tribudubois.net>
Cc: qemu-devel@nongnu.org

Jean-Christophe DUBOIS schrieb:
> From: Jean-Christophe Dubois <jcd@jcd-laptop.(none)>
> 
> Signed-off-by: Jean-Christophe DUBOIS <jcd@tribudubois.net>
> ---
>  block/cloop.c |    6 +++---
>  block/dmg.c   |   14 +++++++-------
>  block/vvfat.c |   36 ++++++++++++++++++------------------
>  3 files changed, 28 insertions(+), 28 deletions(-)

[...]

> 
> diff --git a/block/cloop.c b/block/cloop.c
> index 06c687e..709b7d6 100644
> --- a/block/cloop.c
> +++ b/block/cloop.c
> @@ -148,9 +148,9 @@ static void cloop_close(BlockDriverState *bs)
>      BDRVCloopState *s = bs->opaque;
>      close(s->fd);
>      if(s->n_blocks>0)
> -	free(s->offsets);
> -    free(s->compressed_block);
> -    free(s->uncompressed_block);
> +	qemu_free(s->offsets);
> +    qemu_free(s->compressed_block);
> +    qemu_free(s->uncompressed_block);
>      inflateEnd(&s->zstream);
>  }
>  
> diff --git a/block/dmg.c b/block/dmg.c
> index 262560f..14ebe59 100644
> --- a/block/dmg.c
> +++ b/block/dmg.c
> @@ -273,14 +273,14 @@ static void dmg_close(BlockDriverState *bs)
>      BDRVDMGState *s = bs->opaque;
>      close(s->fd);
>      if(s->n_chunks>0) {
> -	free(s->types);
> -	free(s->offsets);
> -	free(s->lengths);
> -	free(s->sectors);
> -	free(s->sectorcounts);
> +	qemu_free(s->types);
> +	qemu_free(s->offsets);
> +	qemu_free(s->lengths);
> +	qemu_free(s->sectors);
> +	qemu_free(s->sectorcounts);
>      }

Just one small thing I noticed: This indentation looks like tabs. While
you're changing these lines anyway, you could use the chance to correct
the style to use spaces instead. I guess you could do this all over the
patch series.

But there is no need to resend the series if you don't need to change
anything else, of course.

Kevin