From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MI5mZ-0005ek-Lq for qemu-devel@nongnu.org; Sat, 20 Jun 2009 14:59:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MI5mV-0005dK-4i for qemu-devel@nongnu.org; Sat, 20 Jun 2009 14:59:19 -0400 Received: from [199.232.76.173] (port=36153 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MI5mU-0005dD-ST for qemu-devel@nongnu.org; Sat, 20 Jun 2009 14:59:14 -0400 Received: from mx2.redhat.com ([66.187.237.31]:33524) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MI5mU-0008T7-El for qemu-devel@nongnu.org; Sat, 20 Jun 2009 14:59:14 -0400 Message-ID: <4A3D3189.1080307@redhat.com> Date: Sat, 20 Jun 2009 21:59:21 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC References: <20f282157f4df2f513fdb51427be26c7@hotpop.com> <4A3CF2D8.1030908@codemonkey.ws> In-Reply-To: <4A3CF2D8.1030908@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: m a , qemu-devel@nongnu.org On 06/20/2009 05:31 PM, Anthony Liguori wrote: > Please include a Signed-off-by line and use C-style comments instead > of C++ style comments. Otherwise, looks good. What do we have against C++ style comments? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.