From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MI622-0000ky-Am
	for qemu-devel@nongnu.org; Sat, 20 Jun 2009 15:15:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MI61x-0000hz-LA
	for qemu-devel@nongnu.org; Sat, 20 Jun 2009 15:15:17 -0400
Received: from [199.232.76.173] (port=50209 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MI61x-0000ho-Gq
	for qemu-devel@nongnu.org; Sat, 20 Jun 2009 15:15:13 -0400
Received: from mx2.redhat.com ([66.187.237.31]:38869)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MI61x-0003oT-3J
	for qemu-devel@nongnu.org; Sat, 20 Jun 2009 15:15:13 -0400
Message-ID: <4A3D3546.1050407@redhat.com>
Date: Sat, 20 Jun 2009 22:15:18 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC
References: <10665282192-BeMail@laptop>
In-Reply-To: <10665282192-BeMail@laptop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?RnJhbsOnb2lzIFJldm9s?= <revol@free.fr>
Cc: programmingkidx@gmail.com, qemu-devel@nongnu.org

On 06/20/2009 10:03 PM, Fran=C3=A7ois Revol wrote:
>> On 06/20/2009 05:31 PM, Anthony Liguori wrote:
>>     =20
>>> Please include a Signed-off-by line and use C-style comments
>>> instead
>>> of C++ style comments.  Otherwise, looks good.
>>>       =20
>> What do we have against C++ style comments?
>>     =20
>
> They are not valid in C code :P
>   =20

I think C99 allows them.  Too bad date-related jokes are forbidden.

--=20
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.