From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MI7ST-00013B-8R for qemu-devel@nongnu.org; Sat, 20 Jun 2009 16:46:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MI7SO-00012z-4V for qemu-devel@nongnu.org; Sat, 20 Jun 2009 16:46:40 -0400 Received: from [199.232.76.173] (port=45315 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MI7SO-00012w-0S for qemu-devel@nongnu.org; Sat, 20 Jun 2009 16:46:36 -0400 Received: from mail-yx0-f192.google.com ([209.85.210.192]:38558) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MI7SN-0001ol-MM for qemu-devel@nongnu.org; Sat, 20 Jun 2009 16:46:35 -0400 Received: by yxe30 with SMTP id 30so3537156yxe.4 for ; Sat, 20 Jun 2009 13:46:35 -0700 (PDT) Message-ID: <4A3D4AA6.5020502@codemonkey.ws> Date: Sat, 20 Jun 2009 15:46:30 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC References: <20f282157f4df2f513fdb51427be26c7@hotpop.com> <4A3CF2D8.1030908@codemonkey.ws> <4A3D3189.1080307@redhat.com> In-Reply-To: <4A3D3189.1080307@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: m a , qemu-devel@nongnu.org Avi Kivity wrote: > On 06/20/2009 05:31 PM, Anthony Liguori wrote: >> Please include a Signed-off-by line and use C-style comments instead >> of C++ style comments. Otherwise, looks good. > > What do we have against C++ style comments? Just consistency: anthony@squirrel:~/git/qemu$ grep '//' *.c | wc -l 163 anthony@squirrel:~/git/qemu$ grep '/\*' *.c | wc -l 5642 Nothing personal. I think the kernel has a policy of C89 comments only. Regards, Anthony Liguori