From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIA7p-00070c-9Q for qemu-devel@nongnu.org; Sat, 20 Jun 2009 19:37:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIA7k-0006sn-Lp for qemu-devel@nongnu.org; Sat, 20 Jun 2009 19:37:32 -0400 Received: from [199.232.76.173] (port=54482 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIA7k-0006se-GK for qemu-devel@nongnu.org; Sat, 20 Jun 2009 19:37:28 -0400 Received: from yw-out-1718.google.com ([74.125.46.156]:44481) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIA7k-0006f1-73 for qemu-devel@nongnu.org; Sat, 20 Jun 2009 19:37:28 -0400 Received: by yw-out-1718.google.com with SMTP id 5so1345843ywr.82 for ; Sat, 20 Jun 2009 16:37:27 -0700 (PDT) Message-ID: <4A3D72B5.5080806@codemonkey.ws> Date: Sat, 20 Jun 2009 18:37:25 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC References: <20f282157f4df2f513fdb51427be26c7@hotpop.com> <20090620191629.GB25835@lst.de> <20090620233005.GB29958@shareable.org> In-Reply-To: <20090620233005.GB29958@shareable.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jamie Lokier Cc: m a , Christoph Hellwig , qemu-devel@nongnu.org Jamie Lokier wrote: > If O_FSYNC and O_SYNC do the same thing, and O_SYNC is used anywhere, > there's no harm in this for portability: > > #if !defined(O_SYNC) && defined(O_FSYNC) > #define O_SYNC O_FSYNC > #endif > > The patch assumes O_FSYNC is defined if O_SYNC isn't, which is wrong. > For what this patch is, it really isn't that important IMHO. This is just a work around for a broken platform. Regards, Anthony Liguori