From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MIIvZ-00031S-G6
	for qemu-devel@nongnu.org; Sun, 21 Jun 2009 05:01:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MIIvT-000306-Vx
	for qemu-devel@nongnu.org; Sun, 21 Jun 2009 05:01:28 -0400
Received: from [199.232.76.173] (port=40934 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MIIvS-0002zv-W4
	for qemu-devel@nongnu.org; Sun, 21 Jun 2009 05:01:23 -0400
Received: from mx2.redhat.com ([66.187.237.31]:51694)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MIIvS-00019T-1F
	for qemu-devel@nongnu.org; Sun, 21 Jun 2009 05:01:22 -0400
Message-ID: <4A3DF707.3030208@redhat.com>
Date: Sun, 21 Jun 2009 12:01:59 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC
References: <20f282157f4df2f513fdb51427be26c7@hotpop.com>	<4A3CF2D8.1030908@codemonkey.ws>
	<4A3D3189.1080307@redhat.com> <4A3D4AA6.5020502@codemonkey.ws>
In-Reply-To: <4A3D4AA6.5020502@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: m a <programmingkidx@gmail.com>, qemu-devel@nongnu.org

On 06/20/2009 11:46 PM, Anthony Liguori wrote:
> Avi Kivity wrote:
>> On 06/20/2009 05:31 PM, Anthony Liguori wrote:
>>> Please include a Signed-off-by line and use C-style comments instead 
>>> of C++ style comments.  Otherwise, looks good.
>>
>> What do we have against C++ style comments?
>
> Just consistency:
>
> anthony@squirrel:~/git/qemu$ grep '//' *.c | wc -l
> 163
> anthony@squirrel:~/git/qemu$ grep '/\*' *.c | wc -l
> 5642
>

Well, consistency trumps convenience.

> Nothing personal.  I think the kernel has a policy of C89 comments only.

This isn't the kernel, we have our own coding style.  But if we don't 
want C++ comments, that's fine.

-- 
error compiling committee.c: too many arguments to function