From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIRaJ-0007o4-1e for qemu-devel@nongnu.org; Sun, 21 Jun 2009 14:16:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIRaE-0007hc-D5 for qemu-devel@nongnu.org; Sun, 21 Jun 2009 14:16:06 -0400 Received: from [199.232.76.173] (port=43348 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIRaE-0007h4-6v for qemu-devel@nongnu.org; Sun, 21 Jun 2009 14:16:02 -0400 Received: from mx2.redhat.com ([66.187.237.31]:40377) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIRaD-0003ck-QN for qemu-devel@nongnu.org; Sun, 21 Jun 2009 14:16:02 -0400 Message-ID: <4A3E78E8.4080903@redhat.com> Date: Sun, 21 Jun 2009 21:16:08 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] cocoa.m issues fixed References: <61E57A9F-6D9A-4DF3-9CE6-0B8056DD1C60@web.de> <4A3E5071.7080407@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: G 3 , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org On 06/21/2009 09:07 PM, Blue Swirl wrote: > This function prototype would eliminate this warning: >>> cocoa.m:233: warning: no previous prototype for `cocoa_keycode_to_qemu' >>> >>> Why a separate patch. Why not kill two birds with one stone? >>> >>> >> It's standard operating procedure. Suppose in addition to the two birds >> you mention the patch also kills an innocent kitten. Since it's one patch, >> if a fix is not immediately forthcoming, the maintainer has to revert the >> patch, bringing both birds back to life. >> > > How nasty for you to forget the poor little kitten, who should be > entitled to get her life back. > Um, by reverting the patch, the kitten is as good as new. >> With one patch per bird, the maintainer can revert just the patch which >> killed the kitten, leaving the other bird dead. >> > > Also here, do you really hate kittens that much? ;-) > Here too. The kitten is alive and well, as long as we can keep Schroedinger's mitts off of her. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.