From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them?
Date: Mon, 22 Jun 2009 15:36:54 +0300 [thread overview]
Message-ID: <4A3F7AE6.5060509@redhat.com> (raw)
In-Reply-To: <4A3F78EE.2090805@siemens.com>
On 06/22/2009 03:28 PM, Jan Kiszka wrote:
> I just broke (locally) the slirp statistics. You know: "info slirp".
> Maybe you don't because they are off by default, and there is even no
> hidden configure switch to enable them ("#define LOG_ENABLED" or
> "-DLOG_ENABLED" is required). Before fixing them again, I wonder if
> there are actually use cases out there.
>
> Basically I have three options now:
>
> - drop them completely (would make my nice, 1600-lines dropping slirp
> cleanup patch even nicer...)
> - fix them and leave them disabled, maybe adding some
> --enable-slirpstats to configure
> - fix them, but turn them on by default again so that Joe User is able
> to, well, actually look at them
>
> Feedback appreciated.
>
I don't see the need for slirp stats. A production deployment is not
going to use slirp, and a developer deployment won't need slirp stats.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-06-22 12:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 12:28 [Qemu-devel] [POLL] slirp statistics - enable or drop them? Jan Kiszka
2009-06-22 12:36 ` Avi Kivity [this message]
2009-06-22 13:00 ` Jan Kiszka
2009-06-22 14:30 ` Alexander Graf
2009-06-22 14:50 ` Jan Kiszka
2009-06-22 14:51 ` Alexander Graf
2009-06-22 13:09 ` Anthony Liguori
2009-06-22 13:58 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3F7AE6.5060509@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).