From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MIikv-0002Lr-D5
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 08:36:13 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MIikq-0002J1-If
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 08:36:12 -0400
Received: from [199.232.76.173] (port=40074 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MIikq-0002Iy-Dh
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 08:36:08 -0400
Received: from mx2.redhat.com ([66.187.237.31]:35721)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MIikq-0001zo-0Y
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 08:36:08 -0400
Message-ID: <4A3F7AE6.5060509@redhat.com>
Date: Mon, 22 Jun 2009 15:36:54 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them?
References: <4A3F78EE.2090805@siemens.com>
In-Reply-To: <4A3F78EE.2090805@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 06/22/2009 03:28 PM, Jan Kiszka wrote:
> I just broke (locally) the slirp statistics. You know: "info slirp".
> Maybe you don't because they are off by default, and there is even no
> hidden configure switch to enable them ("#define LOG_ENABLED" or
> "-DLOG_ENABLED" is required). Before fixing them again, I wonder if
> there are actually use cases out there.
>
> Basically I have three options now:
>
>   - drop them completely (would make my nice, 1600-lines dropping slirp
>     cleanup patch even nicer...)
>   - fix them and leave them disabled, maybe adding some
>     --enable-slirpstats to configure
>   - fix them, but turn them on by default again so that Joe User is able
>     to, well, actually look at them
>
> Feedback appreciated.
>    

I don't see the need for slirp stats.  A production deployment is not 
going to use slirp, and a developer deployment won't need slirp stats.


-- 
error compiling committee.c: too many arguments to function