From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIjFx-00037P-Ep for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:08:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIjFs-00034l-EL for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:08:16 -0400 Received: from [199.232.76.173] (port=38481 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIjFs-00034Y-1q for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:08:12 -0400 Received: from qw-out-1920.google.com ([74.125.92.147]:8707) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIjFr-0000rd-LY for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:08:11 -0400 Received: by qw-out-1920.google.com with SMTP id 4so1437509qwk.4 for ; Mon, 22 Jun 2009 06:08:11 -0700 (PDT) Message-ID: <4A3F8238.8010903@codemonkey.ws> Date: Mon, 22 Jun 2009 08:08:08 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again References: <1245669483-7076-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1245669483-7076-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Kevin Wolf wrote: > Since the patch that suggested it woudl revert qcow2 to writeback caching, in > fact none of the drivers has had cache=off as default any more. This patch > restores the desired behaviour. > When has cache=off ever been the default? Moreover, why would we want to make it the default? A patch with this drastic of a change really need a more significant justification in the change log. Regards, Anthony Liguori