qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them?
Date: Mon, 22 Jun 2009 08:09:30 -0500	[thread overview]
Message-ID: <4A3F828A.7000806@codemonkey.ws> (raw)
In-Reply-To: <4A3F78EE.2090805@siemens.com>

Jan Kiszka wrote:
> Hi,
>
> I just broke (locally) the slirp statistics. You know: "info slirp".
> Maybe you don't because they are off by default, and there is even no
> hidden configure switch to enable them ("#define LOG_ENABLED" or
> "-DLOG_ENABLED" is required). Before fixing them again, I wonder if
> there are actually use cases out there.
>
> Basically I have three options now:
>
>  - drop them completely (would make my nice, 1600-lines dropping slirp
>    cleanup patch even nicer...)
>   

Yes, I'd say drop them.

What's this "dropping slirp cleanup patch"?  Just something you use 
locally or do you plan on pushing it to the list?

Regards,

Anthony Liguori

  parent reply	other threads:[~2009-06-22 13:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-22 12:28 [Qemu-devel] [POLL] slirp statistics - enable or drop them? Jan Kiszka
2009-06-22 12:36 ` Avi Kivity
2009-06-22 13:00   ` Jan Kiszka
2009-06-22 14:30     ` Alexander Graf
2009-06-22 14:50       ` Jan Kiszka
2009-06-22 14:51         ` Alexander Graf
2009-06-22 13:09 ` Anthony Liguori [this message]
2009-06-22 13:58   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A3F828A.7000806@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).