From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MIjHG-0003nS-VM
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:09:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MIjHC-0003kI-3E
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:09:38 -0400
Received: from [199.232.76.173] (port=38514 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MIjHB-0003k5-US
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:09:33 -0400
Received: from mail-qy0-f191.google.com ([209.85.221.191]:47921)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MIjHB-0001A2-I4
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:09:33 -0400
Received: by qyk29 with SMTP id 29so3592301qyk.4
	for <qemu-devel@nongnu.org>; Mon, 22 Jun 2009 06:09:33 -0700 (PDT)
Message-ID: <4A3F828A.7000806@codemonkey.ws>
Date: Mon, 22 Jun 2009 08:09:30 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them?
References: <4A3F78EE.2090805@siemens.com>
In-Reply-To: <4A3F78EE.2090805@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Jan Kiszka wrote:
> Hi,
>
> I just broke (locally) the slirp statistics. You know: "info slirp".
> Maybe you don't because they are off by default, and there is even no
> hidden configure switch to enable them ("#define LOG_ENABLED" or
> "-DLOG_ENABLED" is required). Before fixing them again, I wonder if
> there are actually use cases out there.
>
> Basically I have three options now:
>
>  - drop them completely (would make my nice, 1600-lines dropping slirp
>    cleanup patch even nicer...)
>   

Yes, I'd say drop them.

What's this "dropping slirp cleanup patch"?  Just something you use 
locally or do you plan on pushing it to the list?

Regards,

Anthony Liguori