From: Kevin Wolf <kwolf@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again
Date: Mon, 22 Jun 2009 15:20:54 +0200 [thread overview]
Message-ID: <4A3F8536.6090906@redhat.com> (raw)
In-Reply-To: <4A3F8238.8010903@codemonkey.ws>
Anthony Liguori schrieb:
> Kevin Wolf wrote:
>> Since the patch that suggested it woudl revert qcow2 to writeback caching, in
>> fact none of the drivers has had cache=off as default any more. This patch
>> restores the desired behaviour.
>>
>
> When has cache=off ever been the default?
>
> Moreover, why would we want to make it the default? A patch with this
> drastic of a change really need a more significant justification in the
> change log.
Hm, you're right. Why is everyone talking about cache=off being default
except for qcow2? This was confusing me. Not handling the default
explicitly but checking the negation of it in 'else if (!(bdrv_flags &
BDRV_O_CACHE_WB))' has done the rest.
Sorry, I take this patch back.
Kevin
next prev parent reply other threads:[~2009-06-22 13:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 11:18 [Qemu-devel] [PATCH] block-raw: Make cache=off default again Kevin Wolf
2009-06-22 11:35 ` Christoph Hellwig
2009-06-22 11:44 ` Kevin Wolf
2009-06-22 11:55 ` Avi Kivity
2009-06-22 12:32 ` Kevin Wolf
2009-06-22 12:39 ` Avi Kivity
2009-06-22 12:50 ` Kevin Wolf
2009-06-23 10:30 ` Jamie Lokier
2009-06-23 11:46 ` Kevin Wolf
2009-06-24 21:23 ` Jamie Lokier
2009-06-25 7:31 ` Kevin Wolf
2009-06-22 13:04 ` Christoph Hellwig
2009-06-22 13:05 ` Kevin Wolf
2009-06-22 13:14 ` Avi Kivity
2009-06-22 13:08 ` Anthony Liguori
2009-06-22 13:20 ` Kevin Wolf [this message]
2009-06-22 14:00 ` Anthony Liguori
2009-06-22 13:23 ` Dor Laor
2009-06-22 13:29 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3F8536.6090906@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).