From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIjTM-0000Qe-QJ for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:22:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIjTG-0000MG-Np for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:22:07 -0400 Received: from [199.232.76.173] (port=35606 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIjTG-0000Lj-1B for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:22:02 -0400 Received: from mx2.redhat.com ([66.187.237.31]:60280) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIjTF-0003Ka-LK for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:22:01 -0400 Message-ID: <4A3F8536.6090906@redhat.com> Date: Mon, 22 Jun 2009 15:20:54 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again References: <1245669483-7076-1-git-send-email-kwolf@redhat.com> <4A3F8238.8010903@codemonkey.ws> In-Reply-To: <4A3F8238.8010903@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Anthony Liguori schrieb: > Kevin Wolf wrote: >> Since the patch that suggested it woudl revert qcow2 to writeback caching, in >> fact none of the drivers has had cache=off as default any more. This patch >> restores the desired behaviour. >> > > When has cache=off ever been the default? > > Moreover, why would we want to make it the default? A patch with this > drastic of a change really need a more significant justification in the > change log. Hm, you're right. Why is everyone talking about cache=off being default except for qcow2? This was confusing me. Not handling the default explicitly but checking the negation of it in 'else if (!(bdrv_flags & BDRV_O_CACHE_WB))' has done the rest. Sorry, I take this patch back. Kevin