From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIjUw-00014R-Rf for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:23:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIjUr-000125-Uf for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:23:46 -0400 Received: from [199.232.76.173] (port=42080 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIjUr-00011q-D9 for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:23:41 -0400 Received: from mx2.redhat.com ([66.187.237.31]:60338) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIjUq-0003cI-VV for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:23:41 -0400 Message-ID: <4A3F85EE.5030109@redhat.com> Date: Mon, 22 Jun 2009 16:23:58 +0300 From: Dor Laor MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] block-raw: Make cache=off default again References: <1245669483-7076-1-git-send-email-kwolf@redhat.com> <4A3F8238.8010903@codemonkey.ws> In-Reply-To: <4A3F8238.8010903@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: dlaor@redhat.com List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , qemu-devel@nongnu.org On 06/22/2009 04:08 PM, Anthony Liguori wrote: > Kevin Wolf wrote: >> Since the patch that suggested it woudl revert qcow2 to writeback >> caching, in >> fact none of the drivers has had cache=off as default any more. This >> patch >> restores the desired behaviour. > > When has cache=off ever been the default? > > Moreover, why would we want to make it the default? A patch with this > drastic of a change really need a more It should be the default (or at least O_DSYNC) since plain users are not aware that writeback might cause their image to get corrupted on host crash. > significant justification in the change log. > > Regards, > > Anthony Liguori > >