From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MIjrz-0002UW-6x for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:47:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MIjrt-0002ST-68 for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:47:33 -0400 Received: from [199.232.76.173] (port=39917 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MIjrs-0002SK-L5 for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:47:28 -0400 Received: from mx2.redhat.com ([66.187.237.31]:52730) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MIjrs-00086C-47 for qemu-devel@nongnu.org; Mon, 22 Jun 2009 09:47:28 -0400 Message-ID: <4A3F8AF1.7040209@redhat.com> Date: Mon, 22 Jun 2009 15:45:21 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 0/10] qdev patches. References: <1245243565-24807-1-git-send-email-kraxel@redhat.com> <4A3A51B9.90207@redhat.com> <4A3BB5F2.9050701@redhat.com> <200906191851.21563.paul@codesourcery.com> In-Reply-To: <200906191851.21563.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org Hi, > In practice there's no way for the user to have more than one set of IDE > busses, so I don't see much point pretending we allow this. i.e. remove the > hd_table argument altogether and use drive_get_index directly. I tend to kill the drives_table[] completely. It mixes host and guest state, we need to separate them. For the host side I think about a linked list built from stripped down DriveInfo which contains the hostside info only (BlockDriverState + friends) and a name to reference it. The guest side will link to the host side state using the name, probably passed as attribute. cheers, Gerd