From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MIk87-0001M8-3e
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:04:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MIk82-0001De-DG
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:04:14 -0400
Received: from [199.232.76.173] (port=33018 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MIk82-0001DH-7v
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:04:10 -0400
Received: from mx2.redhat.com ([66.187.237.31]:49939)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MIk81-0003I8-Di
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 10:04:09 -0400
Message-ID: <4A3F8EDB.5030502@redhat.com>
Date: Mon, 22 Jun 2009 16:02:03 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 0/10] qdev patches.
References: <1245243565-24807-1-git-send-email-kraxel@redhat.com>
	<4A3A51B9.90207@redhat.com> <4A3BB5F2.9050701@redhat.com>
	<200906191851.21563.paul@codesourcery.com>
	<4A3F4BB9.6060604@redhat.com>
In-Reply-To: <4A3F4BB9.6060604@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

   Hi,

>> This is exactly the sort of fake conversion that I don't like, because
>> you
>> still require use of the old hardcoded initialization functions.
>
> I'd prefer to call them "incomplete" instead of "fake". I know that more
> work needs to be done to get the drivers into shape for a dt-driven
> machine creation.

To followup with some more backgroud on that on that:  These are cases 
where additional arguments are passed to the *_init() function.

Partly the reason is irq windup (i.e. passing around qemu_irqs), which 
must be adapted.  Didn't investigate that one yet.  Probably non-trivial 
to the way interrupts work (pic, lapic, ioapic, ...) in PCs.

Partly the arguments carry extra configutation info.  In that case the 
info should probably come as attributes from the the device tree. 
Didn't look (yet) into using attributes, one of the reasons being that 
the API for them is still quite unclear.

cheers,
   Gerd