From: Anthony Liguori <anthony@codemonkey.ws>
To: john cooper <john.cooper@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Add serial number support for virtio_blk
Date: Mon, 22 Jun 2009 14:05:12 -0500 [thread overview]
Message-ID: <4A3FD5E8.1060300@codemonkey.ws> (raw)
In-Reply-To: <4A3FCCEB.1080603@redhat.com>
john cooper wrote:
> [brought forward to current qemu-kvm.git]
>
> This patch implements the missing qemu logic to
> interpret a '-drive .. serial=XYZ ..' flag for
> a virtio_blk device.
>
> The serial number string is contained in a
> skeletal IDENTIFY DEVICE data structure and
> this structure is made available to the guest
> virtio_blk driver via pci i/o region 0.
>
> Signed-off-by: john cooper <john.cooper@redhat.com>
>
I'm trying to write a test case for this functionality. The first thing
I observed is that serial isn't included in info block. Could you add
it? This will let us figure out what the serial number ought to be so
that we can then verify it in the guest.
So far, I don't see a wonderful way to verify a serial number in the
guest. Looks like the information can be gotten indirectly via hdparm
-i or by looking at /dev/disk/by-id. The later doesn't have an easy to
predict name though.
Any thoughts?
I also noticed that if=scsi,serial=XXX doesn't seem to do anything useful.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-06-22 19:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 18:26 [Qemu-devel] [PATCH] Add serial number support for virtio_blk john cooper
2009-06-22 18:46 ` [Qemu-devel] " Anthony Liguori
2009-06-23 12:42 ` john cooper
2009-06-22 19:05 ` Anthony Liguori [this message]
2009-06-22 19:30 ` Gleb Natapov
2009-06-22 20:28 ` Anthony Liguori
2009-06-22 20:38 ` Gleb Natapov
2009-06-22 20:42 ` Daniel P. Berrange
2009-06-23 8:22 ` Gleb Natapov
2009-06-23 12:44 ` john cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3FD5E8.1060300@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=john.cooper@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).