From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MIopT-0003po-MP
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 15:05:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MIopP-0003jw-8B
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 15:05:19 -0400
Received: from [199.232.76.173] (port=40632 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MIopO-0003jk-WC
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 15:05:15 -0400
Received: from mail-qy0-f191.google.com ([209.85.221.191]:48848)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MIopO-0005vT-HU
	for qemu-devel@nongnu.org; Mon, 22 Jun 2009 15:05:14 -0400
Received: by qyk29 with SMTP id 29so3920655qyk.4
	for <qemu-devel@nongnu.org>; Mon, 22 Jun 2009 12:05:14 -0700 (PDT)
Message-ID: <4A3FD5E8.1060300@codemonkey.ws>
Date: Mon, 22 Jun 2009 14:05:12 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4A3FCCEB.1080603@redhat.com>
In-Reply-To: <4A3FCCEB.1080603@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Add serial number support for virtio_blk
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: john cooper <john.cooper@redhat.com>
Cc: qemu-devel@nongnu.org

john cooper wrote:
> [brought forward to current qemu-kvm.git]
>
> This patch implements the missing qemu logic to
> interpret a '-drive .. serial=XYZ ..' flag for
> a virtio_blk device.
>
> The serial number string is contained in a
> skeletal IDENTIFY DEVICE data structure and
> this structure is made available to the guest
> virtio_blk driver via pci i/o region 0.
>
> Signed-off-by: john cooper <john.cooper@redhat.com>
>   
I'm trying to write a test case for this functionality.  The first thing 
I observed is that serial isn't included in info block.  Could you add 
it?  This will let us figure out what the serial number ought to be so 
that we can then verify it in the guest.

So far, I don't see a wonderful way to verify a serial number in the 
guest.  Looks like the information can be gotten indirectly via hdparm 
-i or by looking at /dev/disk/by-id.  The later doesn't have an easy to 
predict name though.

Any thoughts?

I also noticed that if=scsi,serial=XXX doesn't seem to do anything useful.

Regards,

Anthony Liguori