From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ15b-0007tI-Kb for qemu-devel@nongnu.org; Tue, 23 Jun 2009 04:10:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ15X-0007nP-3y for qemu-devel@nongnu.org; Tue, 23 Jun 2009 04:10:47 -0400 Received: from [199.232.76.173] (port=53636 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ15X-0007nM-0y for qemu-devel@nongnu.org; Tue, 23 Jun 2009 04:10:43 -0400 Received: from mx2.redhat.com ([66.187.237.31]:49290) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ15W-0005og-KR for qemu-devel@nongnu.org; Tue, 23 Jun 2009 04:10:42 -0400 Message-ID: <4A408DBF.5010604@redhat.com> Date: Tue, 23 Jun 2009 10:09:35 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Fix net.c coding style (with regard to tabs) References: <1245446552-32015-1-git-send-email-jcd@tribudubois.net> <4A3F40D6.40908@redhat.com> <200906222046.41166.jcd@tribudubois.net> In-Reply-To: <200906222046.41166.jcd@tribudubois.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jean-Christophe Dubois Cc: qemu-devel@nongnu.org Jean-Christophe Dubois schrieb: > Le lundi 22 juin 2009 10:29:10 Kevin Wolf, vous avez =E9crit : >> Jean-Christophe DUBOIS schrieb: >>> This patch will replace existing tab in net.c with spaces >>> in accordance with qemu CODING_STYLE. >>> >>> Note: This first patch is more of a test to see if it >>> will be accepted and if it is worth spending my time on >>> fixing the same issue in other files. >>> >>> Signed-off-by: Jean-Christophe DUBOIS >> I wouldn't do this. We should just pay attention to do it right in cod= e >> touched by new patches. >=20 > Some people are speaking about not killing 2 birds with one stone (and = I don't=20 > speak about the kitten ;-) ) and in general I would think you should fi= x one=20 > problem per patch. I am not sure it is a good idea to ask somebody fixi= ng one=20 > line in a file to also fix all the coding style issues of this same fil= e. Agreed, this is obviously nonsense. I'm just talking about the lines touched by the patch. What I mean is really just "Do it right in new code, leave old code alone". You might argue that this results in files with mixed indentation, but in my experience files using tabs are already mixed in most cases. Anyway, just my personal opinion and I'm not the one who's to decide if we should have such whitespace cleanup patches. Kevin