From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ1md-0005gV-MB for qemu-devel@nongnu.org; Tue, 23 Jun 2009 04:55:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ1mY-0005cq-JG for qemu-devel@nongnu.org; Tue, 23 Jun 2009 04:55:14 -0400 Received: from [199.232.76.173] (port=49050 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ1mW-0005cb-P2 for qemu-devel@nongnu.org; Tue, 23 Jun 2009 04:55:10 -0400 Received: from mx2.redhat.com ([66.187.237.31]:48025) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ1mU-0005bL-NA for qemu-devel@nongnu.org; Tue, 23 Jun 2009 04:55:07 -0400 Message-ID: <4A40989C.1050805@redhat.com> Date: Tue, 23 Jun 2009 11:55:56 +0300 From: Avi Kivity MIME-Version: 1.0 References: <20090623012811.53a62493@doriath> In-Reply-To: <20090623012811.53a62493@doriath> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 01/11] QMP: Introduce specification file List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, dlaor@redhat.com, qemu-devel@nongnu.org On 06/23/2009 07:28 AM, Luiz Capitulino wrote: > This file contains detailed QMP description and definitions. > > Signed-off-by: Luiz Capitulino > --- > monitor-protocol-spec.txt | 180 +++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 180 insertions(+), 0 deletions(-) > create mode 100644 monitor-protocol-spec.txt > > diff --git a/monitor-protocol-spec.txt b/monitor-protocol-spec.txt > new file mode 100644 > index 0000000..d20e3f9 > --- /dev/null > +++ b/monitor-protocol-spec.txt > @@ -0,0 +1,180 @@ > + QEMU Monitor Protocol Specification - Version 0.1 > + > + Luiz Capitulino > + > + > +1. Introduction > +=============== > + > +This document specifies the QEMU Monitor Protocol (QMP), a text-based protocol > +which is available for applications to control QEMU at the machine-level. > Without a doubt, this is a the most important file of this patchset. There's a huge difference between working with an implementation and working with a specification. > + > +For a detailed list of supported commands, please, refer to file > +monitor-protocol-commands.txt. > I don't see you update that file anywhere. In any case, my preference would be to have everything in one file. > +3.1 General definition > +---------------------- > + > + o Only ASCII is permitted > Since the some commands contain user-specified strings, UTF-8 is needed. I think it's worthwhile to define a quoted string format, to be used both in commands and responses. > + > +3.3.1 Server Greeting > +--------------------- > + > +Sent when a new connection is opened. > + > +Format: + OK QEMU QMP > +Example: + OK QEMU 0.10.50 QMP 0.1 > Clients should never make decisions based on the qemu or qmp version. Rather, we should provide a facility to query the availability of features. > + o Command completion failed > + > + Format: - ERR > + Example: - ERR could not find network device 'foo' > + > Maybe add a numeric error code (to be defined by individual commands). > +4.3 Events > +---------- > + > +Client queries the Server about memory, but QEMU reboots. > + > +S: + OK QEMU 0.10.50 QMP 0.1 > +C: info balloon > +S: * EVENT reboot > The guest reboots (actually, resets), not qemu. And 'info balloon' will eventually print its response, no? -- error compiling committee.c: too many arguments to function