From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJ2Vd-0005ZS-3f
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:41:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJ2VX-0005W0-Dk
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:41:44 -0400
Received: from [199.232.76.173] (port=60562 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJ2VX-0005Vm-2P
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:41:39 -0400
Received: from mx2.redhat.com ([66.187.237.31]:54389)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MJ2VW-0003pK-Ie
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:41:38 -0400
Message-ID: <4A40A386.7020102@redhat.com>
Date: Tue, 23 Jun 2009 12:42:30 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <cover.1245730845.git.lcapitulino@redhat.com>
	<20090623012933.5b217767@doriath>
In-Reply-To: <20090623012933.5b217767@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 08/11] QMP: Port balloon command
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, dlaor@redhat.com, qemu-devel@nongnu.org

On 06/23/2009 07:29 AM, Luiz Capitulino wrote:
>       else if (actual == 0)
> -        monitor_printf(mon, "Ballooning not activated in VM\n");
> +        monitor_printf_err(mon, "Ballooning not activated in VM\n");
>       else
> -        monitor_printf(mon, "balloon: actual=%d\n", (int)(actual>>  20));
> +        monitor_printf_data(mon, "balloon: actual=%d\n", (int)(actual>>  20));
>   }
>    

Control mode should always use bytes and seconds (and this should be 
described in the spec).  You avoid rounding, and more importantly, 
ambiguity and a source of unit conversion errors.

Patched that add a command to machine mode without updating the spec 
should be automatically NACKed.

We also need a way to discover that the command is available:

info commands
= info
= balloon
+ OK go for it

info command balloon
+ OK (no extensions yet)

-- 
error compiling committee.c: too many arguments to function