From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJ2Ws-0005vk-RU
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:43:02 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJ2Wo-0005ua-5v
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:43:02 -0400
Received: from [199.232.76.173] (port=55118 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJ2Wn-0005uV-W1
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:42:58 -0400
Received: from mx2.redhat.com ([66.187.237.31]:54410)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MJ2Wn-0004D1-Ev
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:42:57 -0400
Message-ID: <4A40A3D6.3080008@redhat.com>
Date: Tue, 23 Jun 2009 12:43:50 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <cover.1245730845.git.lcapitulino@redhat.com>
	<20090623012944.3f4eba2e@doriath>
In-Reply-To: <20090623012944.3f4eba2e@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 09/11] QMP: Port 'info blockstats' command
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, dlaor@redhat.com, qemu-devel@nongnu.org

On 06/23/2009 07:29 AM, Luiz Capitulino wrote:
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
> ---
>   block.c   |   18 +++++++++---------
>   monitor.c |    3 ++-
>   2 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/block.c b/block.c
> index aca5a6d..3b4af27 100644
> --- a/block.c
> +++ b/block.c
> @@ -1102,15 +1102,15 @@ void bdrv_info_stats(Monitor *mon)
>       BlockDriverState *bs;
>
>       for (bs = bdrv_first; bs != NULL; bs = bs->next) {
> -        monitor_printf(mon, "%s:"
> -                       " rd_bytes=%" PRIu64
> -                       " wr_bytes=%" PRIu64
> -                       " rd_operations=%" PRIu64
> -                       " wr_operations=%" PRIu64
> -                       "\n",
> -                       bs->device_name,
> -                       bs->rd_bytes, bs->wr_bytes,
> -                       bs->rd_ops, bs->wr_ops);
> +        monitor_printf_data(mon, "%s:"
> +                            " rd_bytes=%" PRIu64
> +                            " wr_bytes=%" PRIu64
> +                            " rd_operations=%" PRIu64
> +                            " wr_operations=%" PRIu64
> +                            "\n",
> +                            bs->device_name,
> +                            bs->rd_bytes, bs->wr_bytes,
> +                            bs->rd_ops, bs->wr_ops);
>    

It may be easier for control mode to drop the variable= prefixes (they 
are described in the spec anyway).

-- 
error compiling committee.c: too many arguments to function