From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ2n0-0007qK-6A for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:59:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ2mv-0007om-UC for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:59:41 -0400 Received: from [199.232.76.173] (port=58849 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ2mv-0007oj-Jr for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:59:37 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:19141) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MJ2mv-0007qI-1O for qemu-devel@nongnu.org; Tue, 23 Jun 2009 05:59:37 -0400 Message-ID: <4A40A785.2010504@siemens.com> Date: Tue, 23 Jun 2009 11:59:33 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20090623012944.3f4eba2e@doriath> <4A40A3D6.3080008@redhat.com> In-Reply-To: <4A40A3D6.3080008@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 09/11] QMP: Port 'info blockstats' command List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: aliguori@us.ibm.com, ehabkost@redhat.com, dlaor@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino Avi Kivity wrote: > On 06/23/2009 07:29 AM, Luiz Capitulino wrote: >> Signed-off-by: Luiz Capitulino >> --- >> block.c | 18 +++++++++--------- >> monitor.c | 3 ++- >> 2 files changed, 11 insertions(+), 10 deletions(-) >> >> diff --git a/block.c b/block.c >> index aca5a6d..3b4af27 100644 >> --- a/block.c >> +++ b/block.c >> @@ -1102,15 +1102,15 @@ void bdrv_info_stats(Monitor *mon) >> BlockDriverState *bs; >> >> for (bs = bdrv_first; bs != NULL; bs = bs->next) { >> - monitor_printf(mon, "%s:" >> - " rd_bytes=%" PRIu64 >> - " wr_bytes=%" PRIu64 >> - " rd_operations=%" PRIu64 >> - " wr_operations=%" PRIu64 >> - "\n", >> - bs->device_name, >> - bs->rd_bytes, bs->wr_bytes, >> - bs->rd_ops, bs->wr_ops); >> + monitor_printf_data(mon, "%s:" >> + " rd_bytes=%" PRIu64 >> + " wr_bytes=%" PRIu64 >> + " rd_operations=%" PRIu64 >> + " wr_operations=%" PRIu64 >> + "\n", >> + bs->device_name, >> + bs->rd_bytes, bs->wr_bytes, >> + bs->rd_ops, bs->wr_ops); >> > > It may be easier for control mode to drop the variable= prefixes (they > are described in the spec anyway). > Isn't monitor_printf_data also used for pretty-printing in case of human-operated monitors? I think we need to keep this - or provide two output formats which are filtered by the monitor based on the the target terminal's mode. But that sounds like a lot of work /wrt conversion and long-term maintenance. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux