From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ2nm-00080r-Dh for qemu-devel@nongnu.org; Tue, 23 Jun 2009 06:00:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ2nh-0007zg-Vh for qemu-devel@nongnu.org; Tue, 23 Jun 2009 06:00:30 -0400 Received: from [199.232.76.173] (port=58859 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ2nh-0007zc-IO for qemu-devel@nongnu.org; Tue, 23 Jun 2009 06:00:25 -0400 Received: from mx2.redhat.com ([66.187.237.31]:45509) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ2nh-00080F-0d for qemu-devel@nongnu.org; Tue, 23 Jun 2009 06:00:25 -0400 Message-ID: <4A40A7EC.8070100@redhat.com> Date: Tue, 23 Jun 2009 13:01:16 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1245707244-743-1-git-send-email-andre.przywara@amd.com> In-Reply-To: <1245707244-743-1-git-send-email-andre.przywara@amd.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/2] allow hypervisor CPUID bit to be overriden List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andre Przywara Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org On 06/23/2009 12:47 AM, Andre Przywara wrote: > KVM defaults to the hypervisor CPUID bit to be set, whereas pure QEMU clears > it. On some occasions one want to set or clear it the other way round (for > instance to get HyperV running inside a guest). > Allow the default to be overridden on the command line and fix some > whitespace damage on the way. > It makes sense for qemu to set the hypervisor bit unconditionally. A guest running under qemu is not bare metal. That's a separate change though. Patch looks good. -- error compiling committee.c: too many arguments to function