From: john cooper <john.cooper@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: john.cooper@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Add serial number support for virtio_blk
Date: Tue, 23 Jun 2009 08:44:38 -0400 [thread overview]
Message-ID: <4A40CE36.9000109@redhat.com> (raw)
In-Reply-To: <4A3FD5E8.1060300@codemonkey.ws>
Anthony Liguori wrote:
>
> I'm trying to write a test case for this functionality. The first thing
> I observed is that serial isn't included in info block. Could you add
> it? This will let us figure out what the serial number ought to be so
> that we can then verify it in the guest.
Yes, it seems to be missing for all block devices.
> So far, I don't see a wonderful way to verify a serial number in the
> guest. Looks like the information can be gotten indirectly via hdparm
> -i or by looking at /dev/disk/by-id. The later doesn't have an easy to
> predict name though.
>
> Any thoughts?
Initially I added a new ioctl in the guest driver
to mine out the serial number. Admittedly it was
a wart as both IDE and SCSI already had methods
to accomplish the same. Emulating an IDE IDENTIFY
command was the simplest alternative and allowed
existing utilities such as 'hdparm -i /dev/vda' to
retrieve the information, which is essentially
what I had used to verify the functionality.
-john
--
john.cooper@redhat.com
prev parent reply other threads:[~2009-06-23 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 18:26 [Qemu-devel] [PATCH] Add serial number support for virtio_blk john cooper
2009-06-22 18:46 ` [Qemu-devel] " Anthony Liguori
2009-06-23 12:42 ` john cooper
2009-06-22 19:05 ` Anthony Liguori
2009-06-22 19:30 ` Gleb Natapov
2009-06-22 20:28 ` Anthony Liguori
2009-06-22 20:38 ` Gleb Natapov
2009-06-22 20:42 ` Daniel P. Berrange
2009-06-23 8:22 ` Gleb Natapov
2009-06-23 12:44 ` john cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A40CE36.9000109@redhat.com \
--to=john.cooper@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).