Re: [Qemu-devel] Re: [PATCH 01/11] QMP: Introduce specification file

[Anthony Liguori <anthony@codemonkey.ws>]

Hi Luiz,

The specification looks pretty good.


>> +
>> +3.3.1 Server Greeting
>> +---------------------
>> +
>> +Sent when a new connection is opened.
>> +
>> +Format: + OK QEMU<version>  QMP<version>
>> +Example: + OK QEMU 0.10.50 QMP 0.1
>>    
>
> Clients should never make decisions based on the qemu or qmp version.  
> Rather, we should provide a facility to query the availability of 
> features.

I agree, but I'd suggest leaving the QMP version in there for insurance 
purposes in case we really screw up and need to bump the version.  In 
fact, having the client also negotiate the QMP version isn't a bad idea.

>> + o Command completion failed
>> +
>> +    Format: - ERR<reason>
>> +    Example: - ERR could not find network device 'foo'
>> +
>>    
>
> Maybe add a numeric error code (to be defined by individual commands).

I think copying HTTP makes sense here.

How would asynchronous commands work?  Could you give an example of 
doing live migration through QMP?

Regards,

Anthony Liguori