From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ64H-0001yM-BF for qemu-devel@nongnu.org; Tue, 23 Jun 2009 09:29:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ64C-0001tK-L0 for qemu-devel@nongnu.org; Tue, 23 Jun 2009 09:29:44 -0400 Received: from [199.232.76.173] (port=37798 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ64C-0001tC-Cq for qemu-devel@nongnu.org; Tue, 23 Jun 2009 09:29:40 -0400 Received: from mx2.redhat.com ([66.187.237.31]:44371) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ64B-00012Z-Ul for qemu-devel@nongnu.org; Tue, 23 Jun 2009 09:29:40 -0400 Message-ID: <4A40D8F8.4050508@redhat.com> Date: Tue, 23 Jun 2009 16:30:32 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 01/11] QMP: Introduce specification file References: <20090623012811.53a62493@doriath> <4A40989C.1050805@redhat.com> <4A40D4C1.4040608@codemonkey.ws> In-Reply-To: <4A40D4C1.4040608@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, dlaor@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino On 06/23/2009 04:12 PM, Anthony Liguori wrote: > Hi Luiz, > > The specification looks pretty good. > > >>> + >>> +3.3.1 Server Greeting >>> +--------------------- >>> + >>> +Sent when a new connection is opened. >>> + >>> +Format: + OK QEMU QMP >>> +Example: + OK QEMU 0.10.50 QMP 0.1 >> >> Clients should never make decisions based on the qemu or qmp >> version. Rather, we should provide a facility to query the >> availability of features. > > I agree, but I'd suggest leaving the QMP version in there for > insurance purposes in case we really screw up and need to bump the > version. In fact, having the client also negotiate the QMP version > isn't a bad idea. Agreed. > How would asynchronous commands work? IMO, there aren't any. All commands are synchronous (but may cause events to be generated later). > Could you give an example of doing live migration through QMP? > migrate tcp:blah:4444 +OK don't you love us anymore? * EVENT stopped (migration) * EVENT migration completed -- error compiling committee.c: too many arguments to function