From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJ6Zb-0008T5-0a
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:02:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJ6ZW-0008P1-BE
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:02:06 -0400
Received: from [199.232.76.173] (port=58091 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJ6ZV-0008Om-W3
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:02:02 -0400
Received: from fg-out-1718.google.com ([72.14.220.153]:34442)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MJ6ZV-0000fk-ER
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:02:01 -0400
Received: by fg-out-1718.google.com with SMTP id l27so869226fgb.8
	for <qemu-devel@nongnu.org>; Tue, 23 Jun 2009 07:02:00 -0700 (PDT)
Message-ID: <4A40E050.50300@codemonkey.ws>
Date: Tue, 23 Jun 2009 09:01:52 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 09/11] QMP: Port 'info blockstats' command
References: <cover.1245730845.git.lcapitulino@redhat.com>
	<20090623012944.3f4eba2e@doriath>
In-Reply-To: <20090623012944.3f4eba2e@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, dlaor@redhat.com, qemu-devel@nongnu.org, avi@redhat.com

Luiz Capitulino wrote:
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  block.c   |   18 +++++++++---------
>  monitor.c |    3 ++-
>  2 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/block.c b/block.c
> index aca5a6d..3b4af27 100644
> --- a/block.c
> +++ b/block.c
> @@ -1102,15 +1102,15 @@ void bdrv_info_stats(Monitor *mon)
>      BlockDriverState *bs;
>  
>      for (bs = bdrv_first; bs != NULL; bs = bs->next) {
> -        monitor_printf(mon, "%s:"
> -                       " rd_bytes=%" PRIu64
> -                       " wr_bytes=%" PRIu64
> -                       " rd_operations=%" PRIu64
> -                       " wr_operations=%" PRIu64
> -                       "\n",
> -                       bs->device_name,
> -                       bs->rd_bytes, bs->wr_bytes,
> -                       bs->rd_ops, bs->wr_ops);
> +        monitor_printf_data(mon, "%s:"
> +                            " rd_bytes=%" PRIu64
> +                            " wr_bytes=%" PRIu64
> +                            " rd_operations=%" PRIu64
> +                            " wr_operations=%" PRIu64
> +                            "\n",
> +                            bs->device_name,
> +                            bs->rd_bytes, bs->wr_bytes,
> +                            bs->rd_ops, bs->wr_ops);
>   

monitor_printf_list(mon, bs->device_name,
                              "rd_bytes", MON_BYTES, bs->rd_bytes,
                              "wr_bytes", MON_BYTES, bs->wr_bytes,
                              "rd_operations", MON_BYTES, bs->rd_ops,
                              "wr_operations", MON_BYTES, bs->wr_ops,
                              NULL);

Regards,

Anthony Liguori