From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ7Fy-0002DY-FF for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:45:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ7Ft-00029g-Mv for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:45:53 -0400 Received: from [199.232.76.173] (port=33687 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ7Ft-00029F-7b for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:45:49 -0400 Received: from mx2.redhat.com ([66.187.237.31]:46534) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ7Fs-0002Kp-Fa for qemu-devel@nongnu.org; Tue, 23 Jun 2009 10:45:48 -0400 Message-ID: <4A40EA58.6080600@redhat.com> Date: Tue, 23 Jun 2009 16:44:40 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/2] Fix QCOW2 debugging code to compile with DEBUG_ALLOC defined. References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Filip Navara Cc: qemu-devel@nongnu.org Filip Navara schrieb: > Signed-off-by: Filip Navara > --- > block/qcow2.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 9acbddf..fdcd20b 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -251,7 +251,7 @@ static int qcow_open(BlockDriverState *bs, const char *filename, int flags) > goto fail; > > #ifdef DEBUG_ALLOC > - check_refcounts(bs); > + qcow2_check_refcounts(bs); > #endif > return 0; > Good point. However, this is not complete. During the qcow2 source split the #ifdefs have been spread over the files, but the #define hasn't moved to qcow2.h. To fix debugging you should move it there and fix the additional compile errors in the other files, too. Also, defining DEBUG_ALLOC2 gives even more errors, so maybe they should handled here as well. Kevin