From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ8L7-0001eq-Od for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:55:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ8L2-0001Xe-Mx for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:55:17 -0400 Received: from [199.232.76.173] (port=41642 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ8L2-0001X6-Gg for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:55:12 -0400 Received: from mx2.redhat.com ([66.187.237.31]:53797) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ8L0-0001B8-Eu for qemu-devel@nongnu.org; Tue, 23 Jun 2009 11:55:12 -0400 Message-ID: <4A40FB11.8090100@redhat.com> Date: Tue, 23 Jun 2009 18:56:01 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 01/11] QMP: Introduce specification file References: <20090623012811.53a62493@doriath> <20090623144521.GA614@snarc.org> In-Reply-To: <20090623144521.GA614@snarc.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vincent Hanquez Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, dlaor@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino On 06/23/2009 05:45 PM, Vincent Hanquez wrote: > On Tue, Jun 23, 2009 at 01:28:11AM -0300, Luiz Capitulino wrote: > >> This file contains detailed QMP description and definitions. >> >> Signed-off-by: Luiz Capitulino >> --- >> monitor-protocol-spec.txt | 180 +++++++++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 180 insertions(+), 0 deletions(-) >> create mode 100644 monitor-protocol-spec.txt >> >> diff --git a/monitor-protocol-spec.txt b/monitor-protocol-spec.txt >> new file mode 100644 >> index 0000000..d20e3f9 >> --- /dev/null >> +++ b/monitor-protocol-spec.txt >> @@ -0,0 +1,180 @@ >> + QEMU Monitor Protocol Specification - Version 0.1 >> > > I think this is extremelly needed however inventing yet another RPC protocol > make no sense in 2009, specially with all the limitations (no UTF-8, no quoted > string ...). > > You should really look at what's already out there, so you don't have to > concentrate on the marshalled protocol, but just the format. > > At this point my personal suggestion would be jsonrpc: > > - it's easy to parse (even in C) > - it's text with markup > - easy to generate > - support utf-8 > - quoted string > - it's not ugly to read (compare to xml) > - can be embedded directly (no more library dependancy for qemu) in the code > - lots of language have json library making the interaction with the monitor > easy from the other side > - supports passing structure - supports notifications - supports asynchronous commands seems quite nice. -- error compiling committee.c: too many arguments to function