From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ8R5-0008UY-JJ for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:01:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ8R0-0008RN-QL for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:01:27 -0400 Received: from [199.232.76.173] (port=33914 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ8R0-0008RG-MQ for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:01:22 -0400 Received: from mx2.redhat.com ([66.187.237.31]:54646) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ8R0-0002Y6-05 for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:01:22 -0400 Message-ID: <4A40FC85.7010402@redhat.com> Date: Tue, 23 Jun 2009 19:02:13 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 01/11] QMP: Introduce specification file References: <20090623012811.53a62493@doriath> <4A40989C.1050805@redhat.com> <4A40D4C1.4040608@codemonkey.ws> <4A40D8F8.4050508@redhat.com> <4A40DB6A.8000106@codemonkey.ws> <4A40EE4C.4020009@redhat.com> <4A40F910.1050800@us.ibm.com> In-Reply-To: <4A40F910.1050800@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, jan.kiszka@siemens.com, dlaor@redhat.com, ehabkost@redhat.com, Luiz Capitulino On 06/23/2009 06:47 PM, Anthony Liguori wrote: > Avi Kivity wrote: >>> stop >>> cont >> >> These certainly seem very synchronous to me. > > Not with KVM. You have to wait for the VCPU threads to get notified > and stop. Maybe it's not a big deal to block during this. If a command returns immediately, we shouldn't try to make it asynchronous. >>> migrate >>> balloon >> >> Isn't balloon synchronous? It sets the target and exits >> immediately. We don't want command completion to depend on the guest. > > I can see a use-case for having balloon only return when the target > has been reached by the guest. There's 'info balloon' for that, and maybe request a notification. Waiting for the guest is asking for trouble. What if you want to set the balloon to a different target? you have two different balloon commands running? > > I think I can buy the event stuff. As long as we version QMP > protocol, we can potentially fix this down the road. > Alternatively we can introduce a tag, and so make all commands asynchronous: @tag1 commit @tag1 = committed @tag1 + OK have fun Or go with the jsonrpc thing that has all this built in. -- error compiling committee.c: too many arguments to function