From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJ8yT-0008VC-H6
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:35:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJ8yO-0008Py-I4
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:35:57 -0400
Received: from [199.232.76.173] (port=35391 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJ8yO-0008Pe-6m
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:35:52 -0400
Received: from mx2.redhat.com ([66.187.237.31]:42145)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1MJ8yN-0001Uy-L6
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:35:52 -0400
Message-ID: <4A41049D.9010706@redhat.com>
Date: Tue, 23 Jun 2009 19:36:45 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 08/11] QMP: Port balloon command
References: <cover.1245730845.git.lcapitulino@redhat.com>	<20090623012933.5b217767@doriath>
	<4A40A386.7020102@redhat.com> <4A40DFCE.5050008@codemonkey.ws>
In-Reply-To: <4A40DFCE.5050008@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, dlaor@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

On 06/23/2009 04:59 PM, Anthony Liguori wrote:
>> Control mode should always use bytes and seconds (and this should be 
>> described in the spec).  You avoid rounding, and more importantly, 
>> ambiguity and a source of unit conversion errors.
>
>
> I'd actually like to see a lot more structure in this sort of output.  
> For instance:
>
> monitor_printf_list(mon, "balloon",
>                               "actual", MON_TIME, actual,
>                               NULL);
>
> How this gets output can then be conditional on control mode vs. human 
> mode.  In human mode, we can use human-friendly units like MBs.  In 
> control mode, we would always use bytes.

That actually works well with rpc.  You have a structure that contains 
the data.  For machine mode, you send that away.  For humans, you 
unit-convert, format and print.

>
>> Patched that add a command to machine mode without updating the spec 
>> should be automatically NACKed.
>>
>> We also need a way to discover that the command is available:
>
> I think we want to version each command too.

Not version, discover supported features.

-- 
error compiling committee.c: too many arguments to function