From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJ9KG-0004sF-Md for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:58:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJ9KD-0004qi-2H for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:58:28 -0400 Received: from [199.232.76.173] (port=33655 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJ9KC-0004qb-Pu for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:58:24 -0400 Received: from mail-ew0-f211.google.com ([209.85.219.211]:49554) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJ9KC-0000Ax-9E for qemu-devel@nongnu.org; Tue, 23 Jun 2009 12:58:24 -0400 Received: by ewy7 with SMTP id 7so308028ewy.34 for ; Tue, 23 Jun 2009 09:58:23 -0700 (PDT) Message-ID: <4A4109A9.5020405@codemonkey.ws> Date: Tue, 23 Jun 2009 11:58:17 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 08/11] QMP: Port balloon command References: <20090623012933.5b217767@doriath> <4A40A386.7020102@redhat.com> <4A40DFCE.5050008@codemonkey.ws> <4A41049D.9010706@redhat.com> In-Reply-To: <4A41049D.9010706@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, dlaor@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino Avi Kivity wrote: >> >>> Patched that add a command to machine mode without updating the spec >>> should be automatically NACKed. >>> >>> We also need a way to discover that the command is available: >> >> I think we want to version each command too. > > Not version, discover supported features. That's fine too. capabilities and versions are equivalent AFAICT so as long as one or the other is supported for each command, I'm happy. Regards, Anthony Liguori