From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJ9oX-0000m3-6g
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 13:29:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJ9oS-0000g8-Iy
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 13:29:44 -0400
Received: from [199.232.76.173] (port=45105 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJ9oS-0000fr-3G
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 13:29:40 -0400
Received: from gecko.sbs.de ([194.138.37.40]:15177)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1MJ9oR-00078o-FC
	for qemu-devel@nongnu.org; Tue, 23 Jun 2009 13:29:39 -0400
Message-ID: <4A411100.5000408@siemens.com>
Date: Tue, 23 Jun 2009 19:29:36 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <cover.1245764569.git.quintela@redhat.com>
	<6cd43c2d5e2eed4d683d67915a32496acff33761.1245764569.git.quintela@redhat.com>
In-Reply-To: <6cd43c2d5e2eed4d683d67915a32496acff33761.1245764569.git.quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 05/15] Make --disable-usb to really remove
	usb support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org

quintela@redhat.com wrote:
> From: Juan Quintela <quintela@redhat.com>
> 
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  Makefile          |    7 ++++++-
>  Makefile.target   |    7 ++++++-
>  configure         |   34 ++++++++++++++++++++++------------
>  hw/nseries.c      |    2 ++
>  hw/pc.c           |    2 ++
>  hw/ppc_newworld.c |    2 ++
>  hw/ppc_oldworld.c |    3 ++-
>  hw/ppc_prep.c     |    2 ++
>  hw/pxa2xx.c       |    4 ++++
>  hw/realview.c     |    2 ++
>  hw/usb.h          |    3 +++
>  hw/versatilepb.c  |    2 ++
>  monitor.c         |    2 ++
>  qemu-monitor.hx   |    4 ++++
>  qemu-options.hx   |    2 ++
>  sysemu.h          |    4 ++++
>  vl.c              |   14 +++++++++++---
>  17 files changed, 78 insertions(+), 18 deletions(-)
> 

...

> diff --git a/hw/nseries.c b/hw/nseries.c
> index b412aa0..55648e1 100644
> --- a/hw/nseries.c
> +++ b/hw/nseries.c
> @@ -1314,8 +1314,10 @@ static void n8x0_init(ram_addr_t ram_size, const char *boot_device,
>      n8x0_dss_setup(s);
>      n8x0_cbus_setup(s);
>      n8x0_uart_setup(s);
> +#ifdef CONFIG_USB
>      if (usb_enabled)
>          n8x0_usb_setup(s);
> +#endif

I think there are some good patterns available to avoid this #ifdef all
over the place. Check how kvm_enabled works, e.g.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux