From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJATJ-00074j-AB for qemu-devel@nongnu.org; Tue, 23 Jun 2009 14:11:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJATE-0006xK-Lh for qemu-devel@nongnu.org; Tue, 23 Jun 2009 14:11:52 -0400 Received: from [199.232.76.173] (port=57963 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJATE-0006wj-Fq for qemu-devel@nongnu.org; Tue, 23 Jun 2009 14:11:48 -0400 Received: from mx2.redhat.com ([66.187.237.31]:34048) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJATD-0004Wl-5Q for qemu-devel@nongnu.org; Tue, 23 Jun 2009 14:11:47 -0400 Message-ID: <4A411AE2.6090603@redhat.com> Date: Tue, 23 Jun 2009 21:11:46 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs References: <1245763236-23464-1-git-send-email-avi@redhat.com> <20090623165006.GC27211@lst.de> <4A41095D.7070608@redhat.com> <5b31733c0906231108y28995333s83124722195faf16@mail.gmail.com> In-Reply-To: <5b31733c0906231108y28995333s83124722195faf16@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Filip Navara Cc: Christoph Hellwig , qemu-devel@nongnu.org On 06/23/2009 09:08 PM, Filip Navara wrote: >> Just starting qemu with a vmdk image hangs. I think the very first read >> triggers it. >> > > Actually I think it's the second read ;-) > > Ugh, off-by-one error. > Agreed, let's get this in, the win32 builds are seriously affected by > the bug due to the absence of AIO on the platform. > > Given that it has both threads and true AIO, this could easily be changed. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.