From: Avi Kivity <avi@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs
Date: Tue, 23 Jun 2009 22:50:43 +0300 [thread overview]
Message-ID: <4A413213.5050703@redhat.com> (raw)
In-Reply-To: <20090623194114.GA11045@lst.de>
On 06/23/2009 10:41 PM, Christoph Hellwig wrote:
> On Tue, Jun 23, 2009 at 09:31:55PM +0300, Avi Kivity wrote:
>
>> I meant in an omg we have to look at all the consequences way rather
>> than byte count. This patch is somewhat less local.
>>
>
> My patch makes sure a re-used acb is in the same state as a newly
> allocated one. I think that's much more sensible than messing around
> with some state during freeing some acbs.
>
>
What if it has pointers to allocated stuff it was planning to reuse?
You're leaking memory.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2009-06-23 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 13:20 [Qemu-devel] [PATCH] block: Clean up after deleting BHs Avi Kivity
2009-06-23 13:37 ` Filip Navara
2009-06-23 16:50 ` Christoph Hellwig
2009-06-23 16:57 ` Avi Kivity
2009-06-23 18:08 ` Filip Navara
2009-06-23 18:11 ` Avi Kivity
2009-06-23 18:26 ` Christoph Hellwig
2009-06-23 18:31 ` Avi Kivity
2009-06-23 19:41 ` Christoph Hellwig
2009-06-23 19:50 ` Avi Kivity [this message]
2009-06-23 20:21 ` Filip Navara
2009-06-24 18:31 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A413213.5050703@redhat.com \
--to=avi@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).